Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add User work to VSCode remote connection info #2375

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Apr 26, 2024

resolves https://github.com/lablup/giftbox/issues/666

What changed?

  • Add User work
  • Added styles for ssh-connection-example and vscode-connection-example classes.
  • Updated handling of window.__local_proxy.url check.
  • Refactored HTML structure and added conditional rendering.
  • Modified checkbox and textfield behavior.
  • Added checkbox for allowPreferredPort.
  • style: For dark theme support, refactoring styling codes.

How to test

  1. create a session in electron mode
  2. click session app -> click vscode desktop

Screenshots

Screenshot 2024-04-30 at 12.02.11 PM.png
download_ssh_key.png

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation : docs: update vs code connection guide backend.ai-docs-webui#57
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@agatha197 agatha197 added type:fix Fix features that are not working effort:easy Need to understand only a specific region of codes (good first issue, easy). urgency:3 Must be finished within a certain time frame. platform:general impact:visible This change is visible to users. labels Apr 26, 2024
@agatha197 agatha197 added this to the 24.03 milestone Apr 26, 2024
@agatha197 agatha197 requested a review from yomybaby April 26, 2024 08:32
@agatha197 agatha197 self-assigned this Apr 26, 2024
@github-actions github-actions bot added the size:XS ~10 LoC label Apr 26, 2024
@agatha197 agatha197 marked this pull request as draft April 26, 2024 08:54
@github-actions github-actions bot added size:XL 500~ LoC and removed size:XS ~10 LoC labels Apr 26, 2024
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @agatha197 and the rest of your teammates on Graphite Graphite

@agatha197 agatha197 marked this pull request as ready for review April 26, 2024 09:21
@agatha197 agatha197 requested a review from hoyajigi April 26, 2024 09:55
@agatha197 agatha197 force-pushed the bugfix/vscode-ssh-connection-info-update branch from c6e294a to e5362a0 Compare April 30, 2024 02:38
Copy link

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 2.99% 118/3944
🔴 Branches
3.25% (+0% 🔼)
87/2674
🔴 Functions
1.45% (-0% 🔻)
19/1309
🔴 Lines 2.95% 114/3867

Test suite run success

32 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from e5362a0

@agatha197 agatha197 requested a review from adrysn April 30, 2024 02:46
@agatha197 agatha197 force-pushed the bugfix/vscode-ssh-connection-info-update branch from e5362a0 to 4532a29 Compare April 30, 2024 02:53
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yomybaby yomybaby merged commit 5741237 into main Apr 30, 2024
5 checks passed
@yomybaby yomybaby deleted the bugfix/vscode-ssh-connection-info-update branch April 30, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:easy Need to understand only a specific region of codes (good first issue, easy). impact:visible This change is visible to users. platform:general size:XL 500~ LoC type:fix Fix features that are not working urgency:3 Must be finished within a certain time frame.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants