-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add User work
to VSCode remote connection info
#2375
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agatha197
added
type:fix
Fix features that are not working
effort:easy
Need to understand only a specific region of codes (good first issue, easy).
urgency:3
Must be finished within a certain time frame.
platform:general
impact:visible
This change is visible to users.
labels
Apr 26, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @agatha197 and the rest of your teammates on Graphite |
agatha197
force-pushed
the
bugfix/vscode-ssh-connection-info-update
branch
from
April 30, 2024 02:38
c6e294a
to
e5362a0
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🔴 | Statements | 2.99% | 118/3944 |
🔴 | Branches | 3.25% (+0% 🔼) |
87/2674 |
🔴 | Functions | 1.45% (-0% 🔻) |
19/1309 |
🔴 | Lines | 2.95% | 114/3867 |
Test suite run success
32 tests passing in 4 suites.
Report generated by 🧪jest coverage report action from e5362a0
agatha197
force-pushed
the
bugfix/vscode-ssh-connection-info-update
branch
from
April 30, 2024 02:53
e5362a0
to
4532a29
Compare
yomybaby
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
effort:easy
Need to understand only a specific region of codes (good first issue, easy).
impact:visible
This change is visible to users.
platform:general
size:XL
500~ LoC
type:fix
Fix features that are not working
urgency:3
Must be finished within a certain time frame.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves https://github.com/lablup/giftbox/issues/666
What changed?
User work
ssh-connection-example
andvscode-connection-example
classes.window.__local_proxy.url
check.allowPreferredPort
.How to test
Screenshots
Checklist: (if applicable)