fix: remove comments on config values #2383
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 2.71% | 118/4350 |
| 🔴 | Branches | 2.93% | 87/2968 |
| 🔴 | Functions | 1.33% | 19/1430 |
| 🔴 | Lines | 2.67% | 114/4268 |
Test suite run success
32 tests passing in 4 suites.
Report generated by 🧪jest coverage report action from 20d0818
yomybaby
requested changes
Apr 29, 2024
| // overflow: 'auto', | ||
| alignItems: 'center', |
There was a problem hiding this comment.
Please remove this. When the announcement has multiple lines, it's better to place a close button at the top instead of the middle.
| const uncommentedValue = | ||
| typeof valueObj.value === 'string' && valueObj.value.includes('#') | ||
| ? valueObj.value.split('#')[0].trim() | ||
| : ''; |
There was a problem hiding this comment.
This is not a good idea because the value can have a #.
some="This#Value#has#"
There was a problem hiding this comment.
If the current TOML parser does not support inline comments, please search for an alternative one that supports inline comments.
ironAiken2
force-pushed
the
fix/summary-page-app-download
branch
from
2f4edcd
to
20d0818
Compare
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ironAiken2 and the rest of your teammates on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Resolves #2382 Issue. (and minor fix on summary page's alert margin)
Why the bug occurred
Inside the config.toml file, a description of each value is included as a comment. These comments were being read together to prevent the default value from being used even when no value was provided.
Feature
Checklist: (if applicable)