Omit onOk from BAIModalProps instead of onOK
#2384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @agatha197 and the rest of your teammates on |
yomybaby
approved these changes
Apr 29, 2024
agatha197
force-pushed
the
fix/onOk-props-typo-error
branch
from
5479a00
to
a11aa70
Compare
Merge activity
|
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 2.99% | 118/3942 |
| 🔴 | Branches | 3.25% | 87/2674 |
| 🔴 | Functions | 1.45% | 19/1307 |
| 🔴 | Lines | 2.95% | 114/3865 |
Test suite run success
32 tests passing in 4 suites.
Report generated by 🧪jest coverage report action from a11aa70
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This change fixes the inconsistency in the props of EndpointTokenGenerationModal.tsx.
What changed?
Property 'onOK' is corrected to 'onOk' in EndpointTokenGenerationModal.tsx.
How to test?
Pull the changes, and verify the property in the EndpointTokenGenerationModal.tsx component.
Why make this change?
The change was necessary to align with the correct property name and prevent potential prop related issues.
Checklist: (if applicable)