Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add towncrier_tool pants plugin #427

Merged
merged 24 commits into from Jun 3, 2022

Conversation

achimnol
Copy link
Member

@achimnol achimnol commented Jun 1, 2022

This PR adds a new local pants plugin to enable running towncrier as a Python tool.

After merging this PR, you should reset your Pants config because it upgrades Pants to a newer version:

$ rm .pants.env pants-local
$ scripts/install-dev.sh  # it is safe to rerun this on a previously set up working copy

@achimnol achimnol added the type:maintenance Maintenance issue. label Jun 1, 2022
@achimnol achimnol self-assigned this Jun 1, 2022
- Also use the exactly specified Pants version when building it from the source
- Remove meaningless `--branch` option (now you can just switch the
  branch of the cloned working copy!)
- If the local pants is reset, delete the git clone of pants to ensure
  removal of prior custom patches.
- Leave running towncrier via `./pants towncrier` as a future work.
- Remove deprecation warning about cli-arg target parsing behavior
  changes.
- Remove build config check from non-lint jobs in CI
@achimnol
Copy link
Member Author

achimnol commented Jun 2, 2022

On hold due to bogus CI failures by pantsbuild/pants#15720.

@achimnol
Copy link
Member Author

achimnol commented Jun 3, 2022

Rolled back Pants to 2.12.0rc2 and revived the linux-arm64 awareness patch with an updated diff.

@achimnol achimnol merged commit 6c2a3ca into main Jun 3, 2022
@achimnol achimnol deleted the feature/add-pants-plugin-for-towncrier branch June 3, 2022 03:16
@Yaminyam Yaminyam added the size:XL 500~ LoC label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XL 500~ LoC type:maintenance Maintenance issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants