-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add towncrier_tool pants plugin #427
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also use the exactly specified Pants version when building it from the source
- Remove meaningless `--branch` option (now you can just switch the branch of the cloned working copy!) - If the local pants is reset, delete the git clone of pants to ensure removal of prior custom patches.
- Leave running towncrier via `./pants towncrier` as a future work. - Remove deprecation warning about cli-arg target parsing behavior changes.
- Remove build config check from non-lint jobs in CI
This reverts commit 13c9238.
On hold due to bogus CI failures by pantsbuild/pants#15720. |
Rolled back Pants to 2.12.0rc2 and revived the linux-arm64 awareness patch with an updated diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new local pants plugin to enable running
towncrier
as a Python tool.After merging this PR, you should reset your Pants config because it upgrades Pants to a newer version: