feat: Mutual-exclusion of manager/agent embedded plugins #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Properly define and use the `blocklist` class attribute of plugin context objects
achimnol
added
comp:common
achimnol
deleted the
feature/manager-agent-mutual-exclusion-of-embedded-plugins
branch
achimnol
added a commit
that referenced
this pull request
Jun 8, 2022
* Properly define and use the `blocklist` class attribute of plugin context objects * test: Update mocks with blocklist Backported-From: main (22.06) Backported-To: 22.03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the manager and agent reside inside the same virtualenv (e.g.,
./pants export), the agent tries to detect and load the manager-embedded monitor plugins which are incompatible. Fortunately this have been covered by a tiny compatibility checks and a warning, but such situation should be avoided.Let's allow subclasses of
BasePluginContextto define their ownblocklistclass attributes and utilize them to mutually exclude self-embedded plugins in manager and agent.(i.e., agent should not load the manager-embedded plugins and vice versa.)