Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip measuring the stat for an agent registry item if it has not yet assigned container ID to prevent the occasional unhandled UnboundLocalError #478

Conversation

adrysn
Copy link
Member

@adrysn adrysn commented Jun 16, 2022

Sometimes, the UnboundLocalError is raised due to the missing container ID in one of the agent registry items. To avoid this unhandled exception, this PR skips adding, or referencing, the container ID from the kernel_id_map.

image

@adrysn adrysn self-assigned this Jun 16, 2022
@adrysn adrysn added type:bug Reports about that are not working comp:agent Related to Agent component minor labels Jun 16, 2022
@adrysn adrysn added this to the 22.03 milestone Jun 16, 2022
@adrysn adrysn requested a review from achimnol June 16, 2022 14:30
@achimnol achimnol merged commit 772bea7 into main Jun 22, 2022
@achimnol achimnol deleted the fix/unhandled-exception-when-container-id-is-not-yet-filled-in-agent-registry branch June 22, 2022 05:23
@inureyes inureyes added effort:easy Need to understand only a specific region of codes (good first issue, easy). and removed minor labels Apr 10, 2023
@Yaminyam Yaminyam added the size:XS ~10 LoC label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:agent Related to Agent component effort:easy Need to understand only a specific region of codes (good first issue, easy). size:XS ~10 LoC type:bug Reports about that are not working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants