fix: Type correction on renaming file api #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizable
added
type:bug
achimnol
reviewed
Jun 23, 2022
| @@ -165,15 +164,18 @@ async def request( | |||
| try: | |||
| error_data = await client_resp.json() | |||
| raise VFolderOperationFailed( | |||
| extra_msg=error_data.pop("msg"), | |||
| @@ -485,7 +485,7 @@ async def rename_file(request: web.Request) -> web.Response: | |||
| t.Key("vfid"): tx.UUID(), | |||
| t.Key("relpath"): tx.PurePath(relative_only=True), | |||
| t.Key("new_name"): t.String(), | |||
| t.Key("is_dir"): t.ToBool(), # ignored since 22.03 | |||
There was a problem hiding this comment.
You don't have to remove parenthesis of t.ToBool() because Trafaret automatically handles the difference of type reference and instance reference when there is no argument of a trafaret class.
achimnol
approved these changes
Jun 23, 2022
achimnol
pushed a commit
that referenced
this pull request
Jun 23, 2022
* fix: Set default value for `is_dir` param in renaming file function * fix: Add exception handling on storage related request on manager component Backported-From: main (22.06) Backported-To: 22.03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves two things; setting the default value for
is_dirparameter in the rename_file function, and providing more precise message in exception handling when virtual folder operation errors occurred on the same function.I confirmed this issue during E2E testing for #443.
Screenshot(s)