fix: Correct CPU arch detection in install-dev.sh
#505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix to check machine arch clearly make sure to check machine architecture clearly to query the docker registry
fix docker multiarch url for arm64,aarch64
fix if conditions
fix if condition
studioego
added
comp:installer
add change log for PR
achimnol
approved these changes
Jul 1, 2022
achimnol
changed the title
install-dev.sh
achimnol
pushed a commit
that referenced
this pull request
Jul 1, 2022
Backported-From: main (22.06) Backported-To: 22.03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix to check machine arch clearly
make sure to check machine architecture clearly to query the Docker registry.
Sometimes, some Linux VM's
$(uname -p)result is 'Unknown'. So, changed$(uname -p)to$(uname -m)and clearly showsarm64andaarch64on docker image pulling.