Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(install-dev): Warn and exit if user is not on the build root. #524

Merged
merged 2 commits into from Jul 7, 2022
Merged

feat(install-dev): Warn and exit if user is not on the build root. #524

merged 2 commits into from Jul 7, 2022

Conversation

achimnol
Copy link
Member

@achimnol achimnol commented Jul 7, 2022

Sometimes it is confusing that we should run install-dev.sh from the build root instead of the inside of scripts directory.

@achimnol achimnol added this to the 22.03 milestone Jul 7, 2022
@achimnol achimnol added the comp:installer Related to Installer label Jul 7, 2022
@achimnol achimnol self-assigned this Jul 7, 2022
@achimnol achimnol merged commit 7ac74cd into main Jul 7, 2022
@achimnol achimnol deleted the feature/ensure-buildroot-at-install-dev branch July 7, 2022 06:16
achimnol added a commit that referenced this pull request Jul 7, 2022
@achimnol
feat(install-dev): Warn and exit if user is not on the build root. (#524
1f7616a 
)

Backported-From: main (22.06)
Backported-To: 22.03
@Yaminyam Yaminyam added the size:XS ~10 LoC label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@achimnol achimnol

Labels
comp:installer Related to Installer size:XS ~10 LoC
Projects
None yet
Milestone
22.03
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@achimnol @Yaminyam