Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agent): Introduce var-base-path config and relocate last registry db #529

Merged
merged 22 commits into from Jul 17, 2022

Conversation

KangJuSeong
Copy link
Contributor

resolve issue #489

@KangJuSeong KangJuSeong added type:feature Add new features comp:agent Related to Agent component effort:easy Need to understand only a specific region of codes (good first issue, easy). labels Jul 8, 2022
@KangJuSeong KangJuSeong requested a review from achimnol July 8, 2022 10:49
@KangJuSeong KangJuSeong linked an issue Jul 8, 2022 that may be closed by this pull request
@KangJuSeong KangJuSeong changed the title Feat/relocate last registry feat: relocate last registry Jul 11, 2022
Copy link
Member

@achimnol achimnol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
Check out a minor comment please.

tests/agent/conftest.py Outdated Show resolved Hide resolved
@achimnol
Copy link
Member

Please resolve the merge conflicts by running git merge main in your PR branch.

@achimnol achimnol changed the title feat: relocate last registry feat(agent): Introduce var-base-path config and relocate last registry db Jul 15, 2022
@achimnol achimnol merged commit 8db5050 into main Jul 17, 2022
@achimnol achimnol deleted the feat/relocate-last-registry branch July 17, 2022 03:55
@achimnol achimnol added this to the 22.03 milestone Jul 17, 2022
achimnol added a commit that referenced this pull request Jul 17, 2022
…try db (#529)

* Add `var-base-path` agent configuration parameter
* Upon agent's startup, automatically relocate the last-registry file
  from `ipc-base-path` to `var-base-path`
* `install-dev.sh` now explicitly configures `var-base-path` of agent.

Co-authored-by: Joongi Kim <joongi@lablup.com>
Backported-From: main (22.06)
Backported-To: 22.03
@KangJuSeong KangJuSeong self-assigned this Aug 4, 2022
@Yaminyam Yaminyam added the size:M 30~100 LoC label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:agent Related to Agent component effort:easy Need to understand only a specific region of codes (good first issue, easy). size:M 30~100 LoC type:feature Add new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relocate last_registry.dat to a persistent directory
3 participants