-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(agent): Introduce var-base-path
config and relocate last registry db
#529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KangJuSeong
added
type:feature
Add new features
comp:agent
Related to Agent component
effort:easy
Need to understand only a specific region of codes (good first issue, easy).
labels
Jul 8, 2022
achimnol
requested changes
Jul 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
Check out a minor comment please.
Please resolve the merge conflicts by running |
achimnol
changed the title
feat: relocate last registry
feat(agent): Introduce Jul 15, 2022
var-base-path
config and relocate last registry db
achimnol
added a commit
that referenced
this pull request
Jul 17, 2022
…try db (#529) * Add `var-base-path` agent configuration parameter * Upon agent's startup, automatically relocate the last-registry file from `ipc-base-path` to `var-base-path` * `install-dev.sh` now explicitly configures `var-base-path` of agent. Co-authored-by: Joongi Kim <joongi@lablup.com> Backported-From: main (22.06) Backported-To: 22.03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp:agent
Related to Agent component
effort:easy
Need to understand only a specific region of codes (good first issue, easy).
size:M
30~100 LoC
type:feature
Add new features
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve issue #489