Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix typo & check file on install-dev.sh #551

Merged
merged 6 commits into from Jul 15, 2022

Conversation

studioego
Copy link
Contributor

@studioego studioego commented Jul 14, 2022

Fix typo & check file on install-dev.sh

  1. fix typo & check file on install-dev.sh

1. fix type on install-dev.sh
2. checking a file on buildscript path
@studioego studioego added type:bug Reports about that are not working comp:installer Related to Installer type:refactor Refactoring current implementation. labels Jul 14, 2022
@studioego studioego requested a review from achimnol July 14, 2022 17:30
@studioego studioego self-assigned this Jul 14, 2022
@studioego studioego changed the title fix: fix typo on install-dev & checking a file on buildscript path fix: fix typo on install-dev.sh & checking a file on buildscript path Jul 14, 2022
add change log
Copy link
Member

@achimnol achimnol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

entrypoint.py is already fixed in #550.
Please remove the changes here. 😉

rollback entrypoint.py from main branch
@studioego studioego changed the title fix: fix typo on install-dev.sh & checking a file on buildscript path fix: fix typo & check file on install-dev.sh Jul 15, 2022
modify change log
@studioego studioego requested a review from achimnol July 15, 2022 01:57
scripts/install-dev.sh Outdated Show resolved Hide resolved
fix the file location
@studioego studioego requested a review from achimnol July 15, 2022 03:01
modify install-dev.sh
@achimnol achimnol merged commit 09f7967 into main Jul 15, 2022
@achimnol achimnol deleted the fix/install-dev-check-files branch July 15, 2022 05:18
achimnol pushed a commit that referenced this pull request Jul 15, 2022
Backported-From: main (22.06)
Backported-To: 22.03
@Yaminyam Yaminyam added the size:XS ~10 LoC label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:installer Related to Installer size:XS ~10 LoC type:bug Reports about that are not working type:refactor Refactoring current implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants