feat: Support separate advertise URL for WSProxy v2 #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from the coordinator
adrysn
added
type:feature
achimnol
requested changes
Jul 25, 2022
achimnol
approved these changes
Jul 25, 2022
achimnol
changed the title
achimnol
pushed a commit
that referenced
this pull request
Jul 25, 2022
Backported-From: main (22.06) Backported-To: 22.03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return WSProxy advertise URL, if exists, by querying the value from the coordinator in starting an app service. Since the coordinator's
statushandler now returns the advertise address, thequery_wsproxy_versionmethod is renamed toquery_wsproxy_status.This PR resolves #581.