setup: Reorganize BUILD files #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achimnol
added
area:infrastructure
- This will be the default in Pants 2.14
- Migrate ai.backend.common.test_utils to ai.backend.testutils.mock - Drop `asynctest` from our dependnecies as it is only required for Python 3.7 or lower versions
- Ensure initialization of `LocalLogger` before bootstrapping database containers in test fixtures
achimnol
added a commit
that referenced
this pull request
Aug 9, 2022
* setup: Revamp BUILD files of the entire codebase
- Let Pants auto-infer when possible
- Move test dependencies to `pytest_test_utils()` target
- Manually specify internal dependencies that are not auto-inferred
due to indirect imports by pkg/module names or entrypoint scans
* setup: Disable tailoring pex_binary targets
- This will be the default in Pants 2.14
* refactor: Migrate `ai.backend.common.test_utils` to `ai.backend.testutils.mock`
* setup: Drop `asynctest` from our dependnecies as it is only required for
Python 3.7 or lower versions
* fix: Random failure of `wait_health_check()` due to docker API responses
* fix: Improve error detection of bootstrap container spawning
Backported-From: main
Backported-To: 22.03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Pants, using per-directory BUILD files works better than globbing a filename pattern under a directory rescursively when specifying fine-grained targets.
Let's remove the glob patterns and use per-directory BUILD files.
Also, let's unify the target naming:
:lib,:service->:src.