Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Pin hiredis version to 1.1.0 instead of the inferred version 2.0 #636

Merged
merged 5 commits into from Aug 8, 2022
Merged

fix: Pin hiredis version to 1.1.0 instead of the inferred version 2.0 #636

merged 5 commits into from Aug 8, 2022

Conversation

studioego
Copy link
Contributor

fix: change hiredis ver. 2.0.0 to 1.1.0

Because, hiredis test case result log reveal malloc errors

➜  hiredis-py-c99 git:(fix/travis-ci-add-cflag-c99) ✗ python test.py
.......................................................
----------------------------------------------------------------------
Ran 55 tests in 0.002s

OK
python(42561,0x1011a4580) malloc: *** error for object 0x100c5a880: pointer being freed was not allocated
python(42561,0x1011a4580) malloc: *** set a breakpoint in malloc_error_break to debug
[1]    42561 abort      python test.py

As a result, I change hiredis ver. 2.0.0 to 1.1.0

@studioego
fix: change hiredis ver. 2.0.0 to 1.1.0
67e12df 
fix: change hiredis ver. 2.0.0 to 1.1.0
@studioego studioego added the comp:installer Related to Installer label Aug 8, 2022
@studioego studioego requested a review from achimnol August 8, 2022 02:07
@studioego studioego self-assigned this Aug 8, 2022
@studioego
add change log
a8beb12 
add change log
achimnol
achimnol requested changes Aug 8, 2022
View reviewed changes
Copy link
Member

@achimnol achimnol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include the updated requirements.txt.
Also, remove the trailing newline of changelog and use the capital letter of the first character of the changelog sentence to keep consistency with the changelog writing style.

@studioego
updated requirements.txt, modify change log
9d4b36b 
updated requirements.txt, modify change log
@studioego studioego requested a review from achimnol August 8, 2022 15:20
@achimnol achimnol changed the title fix: change hiredis ver. 2.0.0 to 1.1.0 fix: Pin hiredis version to 1.1.0 instead of the inferred version 2.0 Aug 8, 2022
@achimnol achimnol added this to the 22.03 milestone Aug 8, 2022
@achimnol achimnol merged commit be8dcbd into main Aug 8, 2022
@achimnol achimnol deleted the fix/chg-hiredis-ver-2to1 branch August 8, 2022 16:43
achimnol pushed a commit that referenced this pull request Aug 8, 2022
@studioego @achimnol
fix: Pin hiredis version to 1.1.0 instead of the inferred version 2.0 (…
e70ab65 
…#636)

Backported-From: main
Backported-To: 22.03
@achimnol achimnol mentioned this pull request Aug 8, 2022
Closed
@studioego studioego mentioned this pull request Feb 8, 2023
Closed
@Yaminyam Yaminyam added the size:L 100~500 LoC label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achimnol achimnol achimnol approved these changes

Assignees

@studioego studioego

Labels
comp:installer Related to Installer size:L 100~500 LoC
Projects
None yet
Milestone
22.03
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@studioego @achimnol @Yaminyam