feat: Support the asyncio debug mode and apply aiomonitor-ng #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achimnol
added
type:feature
github-actions
bot
added
comp:agent
|
the port number of aiomonitors changes due to better management of ports? |
Manager and agent's aiomonitor ports were overlapping when there are two or more worker processes in the manager (the actual aiomonitor port used by each worker process = the configured port number + |
achimnol
changed the title
- The "creation location" in the ps command output was wrong because 0.5.0 retrieved the other end of the stack.
adrysn
approved these changes
Aug 29, 2022
|
I will make separate PRs for future updates of aiomonitor-ng. |
achimnol
added a commit
that referenced
this pull request
Aug 30, 2022
* feat: Add `[debug].{asyncio,enhanced-aiomonitor-task-info}` config flags
in the manager, agent, and storage-proxy TOML files
* fix: Prevent overlapping of manager/agent aiomonitor ports by changing
the default ports to have more distant values (50100, 50200).
* setup: Replace aiomonitor with aiomonitor-ng
* feat: Add aiomonitor support to storage-proxy (default port: 50300)
Backported-From: main
Backported-To: 22.03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the asyncio debug mode is enabled, it additionally keeps track of the stack trace of where the tasks are created though this behavior is undocumented.
Chaining of full task creation/cancellation tracebacks is handled in our modified aiomonitor.
This PR also fixes missing sample configurations for aiomonitor ports and changes the default value of them to avoid overlapping of the aiomonitor ports in manager and agent when they run in a same host (e.g., development setups).