Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify crates #40

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Unify crates #40

merged 2 commits into from
Jul 4, 2023

Conversation

sanxiyn
Copy link
Contributor

@sanxiyn sanxiyn commented Jul 4, 2023

Fix #39.

Following mechanical changes were made:

  • Delete Cargo.toml in subdirectories and update toplevel Cargo.toml.
  • Rename lib.rs in subdirectories to mod.rs and move lint directives to toplevel lib.rs.
  • Add mod declarations to toplevel lib.rs.
  • Prefix use utils (and bindings, external_bindings, raftpb_bindings) with crate::.
  • Except for implement_type_conversion, which is a macro.
  • Also use $crate in a macro.
  • Change use crate:: to use super::.
  • Delete rust-toolchain.toml. (We are now on stable.)

@sanxiyn sanxiyn requested a review from jopemachine July 4, 2023 03:18
@jopemachine jopemachine merged commit f64a7c8 into main Jul 4, 2023
2 checks passed
@jopemachine jopemachine deleted the unify-crates branch July 4, 2023 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring project directory structure
2 participants