Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does travis run scalalabrad and test pylabrad servers? #325

Closed
jayich opened this issue Apr 2, 2017 · 3 comments
Closed

Does travis run scalalabrad and test pylabrad servers? #325

jayich opened this issue Apr 2, 2017 · 3 comments

Comments

@jayich
Copy link
Member

jayich commented Apr 2, 2017

@maffoo , from https://github.com/labrad/pylabrad/blob/master/.travis.yml it looks like pylabrad servers are launched on travis and tested.

I am interested in doing the same here

I am curious if there is a reason other than time that similar testing is not implemented in martinisgroup/servers

@maffoo
Copy link
Contributor

maffoo commented Apr 3, 2017

You're correct that on travis we spin up a scalabrad manager as well as some python servers and test them. The main reason we haven't set up something similar on the servers repo directly is that most of the servers there are for interfacing to hardware, so it's rather hard to set up automated tests in a sandboxed environment without that hardware. There are some exceptions for which automated tests would be useful, like the datavault, we just haven't set it up.

@jayich
Copy link
Member Author

jayich commented Apr 3, 2017

Besides following pylabrad's .travis.yml, and having the bash script install-scalabrad.sh is there anything else I should be aware of or need to setup scalabrad on travis for testing purposes?

@maffoo , thank you.

@maffoo
Copy link
Contributor

maffoo commented Apr 3, 2017

@jayich, I don't think so, but it seems like something always comes up when messing with the travis configuration, so you may find some issues. I generally turn on the "Build Branch Updates" option in travis for the repository so it will run tests on branches you push. Then you can make changes to the travis config on a branch, push the branch, watch the tests run, repeat until things are working, and finally merge to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants