Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: issue with InputDataModal and controller.ts #1099

Closed
wants to merge 1 commit into from

Conversation

Fengrui-Liu
Copy link
Contributor

@Fengrui-Liu Fengrui-Liu commented Mar 29, 2024

image

  1. projects/app/src/service/core/dataset/data/controller.ts, indexes is a list.
  2. projects/app/src/pages/dataset/detail/components/InputDataModal.tsx getDefaultIndex creates an Index with empty text, which cannot be parsed correctly in controller.ts. I moved it because it can be auto created at here

how to replay this bug:

  1. add a new index
    image
  2. delete the new index
  3. import it

Copy link
Collaborator

@c121914yu c121914yu Apr 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个不需要的。目前禁止删掉默认的了,所以长度肯定>=1
插入时,都会自动补充索引。

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
改成z这样子,否则在解构时候会报错

@c121914yu
Copy link
Collaborator

我改掉了

@c121914yu c121914yu closed this Apr 3, 2024
@c121914yu c121914yu mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants