Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize apk install process in Dockerfile #553

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

PeterDaveHello
Copy link
Contributor

Merge two apk install commands and use the --no-cache parameter to minimize the temporary files left in the Docker image.

I also noticed that there were different apk install processes in the Dockerfile. The second one has the process to replace https with http in /etc/apk/repositories before the installation, but the first one doesn't, meaning the process is unnecessary.

Copy link

cla-assistant bot commented Dec 4, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Dec 4, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

sweep-ai bot commented Dec 4, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@c121914yu c121914yu merged commit c3ae38d into labring:main Dec 4, 2023
1 check was pending
@PeterDaveHello PeterDaveHello deleted the Dockerfile branch December 4, 2023 13:29
@c121914yu
Copy link
Collaborator

Yes, the initial installation can also use no cache.

@PeterDaveHello
Copy link
Contributor Author

Could do so for best practice. The reason why I didn't do it is because that image shouldn't affect the one that will be released 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants