Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tty清理功能无效 #88

Closed
fanux opened this issue Mar 22, 2019 · 2 comments
Closed

tty清理功能无效 #88

fanux opened this issue Mar 22, 2019 · 2 comments
Assignees
@dujiacheng
Labels
bug Something isn't working

Comments

@fanux
Copy link
Member

fanux commented Mar 22, 2019

切一个bug fix分支，修复这个bug。

  • 不需要每个terminal都创建一个协程
  • 主程序启动时创建一个tty清理线程即可，每隔10min清理一下 sealyun-tty namespace下的超时 tty
@fanux fanux added the bug Something isn't working label Mar 22, 2019
@cuisongliu
Copy link
Collaborator

https://github.com/fanux/fist/blob/a74d09f85bf912c5a28e1506ab9e3c6ed3fcd4a5/terminal/server.go#L73
在server启动时候开启清理线程是不是好一些？

@fanux
Copy link
Member Author

fanux commented Mar 22, 2019

可以

@dujiacheng dujiacheng mentioned this issue Mar 22, 2019
Closed
@cuisongliu cuisongliu mentioned this issue Mar 23, 2019
Merged
cuisongliu added a commit that referenced this issue Mar 23, 2019
@cuisongliu
Merge pull request #95 from cuisongliu/auth-user
b120cf4 
fix bug #88 tty clean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dujiacheng dujiacheng

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cuisongliu @fanux @dujiacheng