Skip to content

Commit

Permalink
refactor(cloud-sdk): refactor listFiles paramsof cloud sdk (#1735)
Browse files Browse the repository at this point in the history
  • Loading branch information
maslow committed Dec 19, 2023
1 parent 3f21ef5 commit 290fb3f
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 16 deletions.
4 changes: 2 additions & 2 deletions packages/cloud-sdk/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/cloud-sdk/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@lafjs/cloud",
"version": "1.0.0-beta.13-storage-pr4",
"version": "1.0.0-beta.13-storage-pr5",
"description": "The cloud sdk for laf cloud function",
"main": "dist/index.js",
"scripts": {
Expand Down
6 changes: 1 addition & 5 deletions packages/cloud-sdk/src/storage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -267,15 +267,11 @@ export class CloudStorageBucket {
* @returns
* @see https://docs.aws.amazon.com/AmazonS3/latest/API/API_ListObjects.html
*/
public async listFiles(
prefix?: string,
options?: Omit<ListObjectsCommandInput, 'Bucket' | 'Prefix'>
) {
public async listFiles(options?: Omit<ListObjectsCommandInput, 'Bucket'>) {
const internal = this.storage.getInternalS3Client()

const args: ListObjectsCommandInput = {
Bucket: this.name,
Prefix: prefix,
...options,
}
const res = await internal.listObjects(args)
Expand Down
14 changes: 7 additions & 7 deletions runtimes/nodejs/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion runtimes/nodejs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"@aws-sdk/client-sts": "^3.468.0",
"@aws-sdk/s3-request-presigner": "^3.468.0",
"@kubernetes/client-node": "^0.18.0",
"@lafjs/cloud": "^1.0.0-beta.13-storage-pr4",
"@lafjs/cloud": "^1.0.0-beta.13-storage-pr5",
"@types/pako": "^2.0.2",
"axios": "^1.4.0",
"chalk": "^4.1.2",
Expand Down

0 comments on commit 290fb3f

Please sign in to comment.