Skip to content

Commit

Permalink
fix(server): fix certificate not deleting and rebuilding issue when u…
Browse files Browse the repository at this point in the history
…nbundling runtime custom domains (#1829)

Co-authored-by: HUAHUAI23 <lim@outlook.com>
  • Loading branch information
HUAHUAI23 and HUAHUAI23 committed Jan 29, 2024
1 parent b23d2a2 commit 77be144
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion server/src/gateway/runtime-domain-task.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,13 @@ export class RuntimeDomainTaskService {
this.logger.debug(JSON.stringify(res))
}

if (doc.state === DomainState.Deleted) {
/* Certificates are only removed when you delete the application and unbind the custom runtime domain.
Starting, restarting and stopping the application does not remove certificates */

if (
doc.state === DomainState.Deleted ||
(doc.state === DomainState.Active && doc.phase === DomainPhase.Deleting)
) {
// delete app custom certificate if custom domain is set
const waitingTime = Date.now() - doc.updatedAt.getTime()

Expand Down

0 comments on commit 77be144

Please sign in to comment.