fix(runtime): fix process.env hot reload (#1709)

labring · Nov 24, 2023 · 7ef87f5 · 7ef87f5
1 parent 670ab2c
commit 7ef87f5
Show file tree

Hide file tree

Showing 5 changed files with 95 additions and 70 deletions.
diff --git a/runtimes/nodejs/package-lock.json b/runtimes/nodejs/package-lock.json
diff --git a/runtimes/nodejs/package.json b/runtimes/nodejs/package.json
@@ -66,7 +66,7 @@
     "@types/lodash": "^4.14.171",
     "@types/mongodb-uri": "^0.9.1",
     "@types/multer": "^1.4.5",
-    "@types/node": "^18.11.15",
+    "@types/node": "^20.9.5",
     "@types/nodemailer": "^6.4.4",
     "@types/validator": "^13.1.3",
     "@types/ws": "^8.5.3",

diff --git a/runtimes/nodejs/src/support/cloud-sdk.ts b/runtimes/nodejs/src/support/cloud-sdk.ts
@@ -33,9 +33,7 @@ function createCloudSdk() {
     sockets: WebSocketAgent.clients,
     appid: Config.APPID,
     get env() {
-      return {
-        ...process.env,
-      }
+      return process.env
     },
   }
 

diff --git a/runtimes/nodejs/src/support/engine/module.ts b/runtimes/nodejs/src/support/engine/module.ts
@@ -137,9 +137,7 @@ export class FunctionModule {
       clearInterval: clearInterval,
       setTimeout: setTimeout,
       clearTimeout: clearTimeout,
-      process: {
-        env: { ...process.env },
-      },
+      process: process,
       URL: URL,
       fetch: globalThis.fetch,
       global: null,

diff --git a/runtimes/nodejs/src/support/engine/types.ts b/runtimes/nodejs/src/support/engine/types.ts
@@ -27,9 +27,7 @@ export interface FunctionModuleGlobalContext {
   Float32Array: typeof Float32Array
   __filename: string
   URL: typeof URL
-  process: {
-    env: { [key: string]: string }
-  }
+  process: NodeJS.Process
   global: FunctionModuleGlobalContext
   __from_modules: string[]
   fetch: typeof globalThis.fetch