Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web): remove storage.credential #1594

Merged
merged 1 commit into from
Oct 19, 2023
Merged

fix(web): remove storage.credential #1594

merged 1 commit into from
Oct 19, 2023

Conversation

newfish-cmyk
Copy link
Contributor

No description provided.

@newfish-cmyk newfish-cmyk marked this pull request as ready for review October 19, 2023 08:32
@sweep-ai
Copy link

sweep-ai bot commented Oct 19, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@0fatal 0fatal merged commit 8e5f568 into labring:main Oct 19, 2023
1 check passed
@newfish-cmyk newfish-cmyk deleted the fix/remove-credential branch October 25, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0fatal 0fatal 0fatal approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@newfish-cmyk @0fatal