Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime): object check #1684

Merged
merged 1 commit into from
Nov 15, 2023
Merged

fix(runtime): object check #1684

merged 1 commit into from
Nov 15, 2023

Conversation

bestlyg
Copy link
Contributor

@bestlyg bestlyg commented Nov 13, 2023

path: laf/runtimes/nodejs/src/handler/invoke.ts

  if (
      typeof result.data === 'object' &&
      result.data.__type__ === '__interceptor__' &&
      result.data.__res__ == false
    ) {
      ...
    }

在函数返回null的时候会报错。
image
image
image

Copy link

cla-assistant bot commented Nov 13, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

sweep-ai bot commented Nov 13, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.

@maslow maslow requested a review from 0fatal November 15, 2023 07:11
@0fatal 0fatal merged commit f2a3a40 into labring:main Nov 15, 2023
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants