Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cloud-sdk): refacct readFile returns in cloud-sdk #1734

Merged
merged 4 commits into from
Dec 12, 2023

Conversation

maslow
Copy link
Member

@maslow maslow commented Dec 12, 2023

No description provided.

Copy link

💥 laf nodejs runtime init image built successfully for pr 1734

ghcr.io/labring/runtime-node-init:pr-1734
docker.io/lafyun/runtime-node-init:pr-1734

Copy link

sweep-ai bot commented Dec 12, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

💥 laf nodejs runtime image built successfully for pr 1734

ghcr.io/labring/runtime-node:pr-1734
docker.io/lafyun/runtime-node:pr-1734

@pull-request-size pull-request-size bot added size/M and removed size/S labels Dec 12, 2023
@maslow maslow merged commit 0873645 into main Dec 12, 2023
3 checks passed
@maslow maslow deleted the refact-storage-read-return branch December 12, 2023 12:47
maslow added a commit that referenced this pull request Dec 19, 2023
* refact read file api

* fix storage api typing missing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant