fix(server): cancel namespace removal while stopping app #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cr-gpt[bot]](https://avatars.githubusercontent.com/in/292659?s=60&v=4){kind=small}
| await this.relock(appid, waitingTime) | ||
| return | ||
| } | ||
|
|
||
| // update application phase to `Stopped` | ||
| await db.collection<Application>('Application').updateOne( | ||
| { appid, phase: ApplicationPhase.Stopping }, |
There was a problem hiding this comment.
the code review.
-
It's a good practice to add comments to explain the logic of the code. In this case, the comment "check if the service is removed" should be added to describe the purpose of the if condition.
-
It is also recommended to use more descriptive variable names. For example, "instance.service" can be replaced with something like "instance.isServiceRemoved".
-
It is better to break the long statement into multiple lines for better readability.
-
Make sure the waitingTime parameter is valid before using it in the relock() method.
| @@ -280,9 +282,6 @@ export class InstanceService { | |||
| const name = appid | |||
| await coreV1Api.deleteNamespacedService(name, namespace.metadata.name) | |||
| } | |||
|
|
|||
| // delete application namespace | |||
| await this.clusterService.removeAppNamespace(region, appid) | |||
| } | |||
|
|
|||
| async get(app: Application) { | |||
There was a problem hiding this comment.
with the code review:
- On line 34, adding a comment helps explain the purpose of the new code. This is a good practice as it makes the code easier to understand and maintain.
- On line 280, the code for deleting the application namespace should be added back in order to properly clean up the environment.
This was referenced May 9, 2023
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.