Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor:smooth and simple new desktop #3059

Merged
merged 4 commits into from
May 12, 2023
Merged

refactor:smooth and simple new desktop #3059

merged 4 commits into from
May 12, 2023

Conversation

zjy365
Copy link
Contributor

@zjy365 zjy365 commented May 8, 2023

🤖 Generated by Copilot at 34fa0b5

Summary

🌐🛠️📚

This pull request updates the frontend desktop project by changing its name and version, removing unused files and scripts, reorganizing the project structure, and adding internationalization support for English and Chinese languages. The changes aim to improve the frontend code quality, performance, and user experience.

Sing, O Muse, of the glorious deeds of the desktop developers
Who, with skill and wisdom, crafted the splendid frontend code
And adorned it with many tongues, both English and Chinese
To delight the eyes and ears of the users across the world.

Walkthrough

  • Change the project name and version in package.json (link)
  • Remove unused or redundant scripts in package.json (link)
  • Update the project dependencies in package.json and README.md (link)
  • Update the directory structure of the project in README.md and delete some unused or redundant directories and files (link, link, link, link, link, link, link, link, link, link, link, link)
  • Add English and Chinese translations for some UI elements in public/locales/en/translation.json and public/locales/zh/translation.json (link, link)
  • Update the code reading instructions in README.md to reflect the new libraries and conventions (link)
  • Delete the iconfont.js file, as it is no longer needed (link)

@pull-request-size
Copy link

Whoa! Easy there, Partner!

This PR is too big. Please break it up into smaller PRs.

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d5cf8f3) 72.30% compared to head (34fa0b5) 72.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3059   +/-   ##
=======================================
  Coverage   72.30%   72.30%           
=======================================
  Files           8        8           
  Lines         603      603           
=======================================
  Hits          436      436           
  Misses        132      132           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

frontend/desktop/src/components/floating_button/index.tsx Outdated Show resolved Hide resolved
frontend/desktop/src/stores/app.ts Outdated Show resolved Hide resolved
frontend/desktop/src/utils/ProcessManager.ts Outdated Show resolved Hide resolved
frontend/desktop/src/utils/ProcessManager.ts Outdated Show resolved Hide resolved
frontend/desktop/src/components/app_window/index.tsx Outdated Show resolved Hide resolved
frontend/desktop/src/utils/ProcessManager.ts Outdated Show resolved Hide resolved
frontend/desktop/src/stores/app.ts Outdated Show resolved Hide resolved
frontend/desktop/src/utils/delay.ts Outdated Show resolved Hide resolved
@zjy365 zjy365 force-pushed the desktop branch 2 times, most recently from 43c55dc to 4c02cdb Compare May 10, 2023 14:14
@zjy365 zjy365 changed the title feat new desktop refactor:smooth and simple new desktop May 10, 2023
frontend/desktop/deploy/Kubefile Outdated Show resolved Hide resolved
frontend/desktop/deploy/README.md Outdated Show resolved Hide resolved
@zjy365 zjy365 requested a review from lingdie May 12, 2023 05:14
Signed-off-by: zhu jing yang <3161362058@qq.com>
Signed-off-by: zhu jing yang <3161362058@qq.com>
Signed-off-by: zhu jing yang <3161362058@qq.com>
Signed-off-by: zhu jing yang <3161362058@qq.com>
@zzjin zzjin merged commit d4a0c51 into labring:main May 12, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants