Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename CopyR to Fetch #3061

Merged
merged 1 commit into from
May 9, 2023
Merged

rename CopyR to Fetch #3061

merged 1 commit into from
May 9, 2023

Conversation

fengxsong
Copy link
Collaborator

@fengxsong fengxsong commented May 9, 2023

rename function name.

πŸ€– Generated by Copilot at 15029e9

Summary

πŸ”πŸ”„πŸ—‘οΈ

Renamed and refactored the CopyR method to Fetch in the pkg/ssh package and its dependencies. This change improves the clarity and consistency of the file copying functionality and removes an unused dependency.

Sing, O Muse, of the skillful refactorer who changed the code
Of the clusterClient and the RemoteCmd, the swift and the bold
Who renamed the CopyR method to Fetch, as clear as the sun
And made it fetch remote files to local, like Hermes the cunning

Walkthrough

  • Rename CopyR method to Fetch and swap parameters for clusterClient, Client, and Interface types (link, link, link)
  • Refactor Fetch method implementation to use better variable names, error handling, and io.Copy function (link)
  • Simplify logging statements in Fetch method to use logger package instead of logrus (link)
  • Remove unused logrus import from scp.go (link)
  • Update RemoteCmd type to use Fetch method and swap parameters in test/e2e/testhelper/cmd/cmd.go (link)

Signed-off-by: fengxsong <fengxsong@outlook.com>
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (db9c47d) 72.30% compared to head (15029e9) 72.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3061   +/-   ##
=======================================
  Coverage   72.30%   72.30%           
=======================================
  Files           8        8           
  Lines         603      603           
=======================================
  Hits          436      436           
  Misses        132      132           
  Partials       35       35           

β˜” View full report in Codecov by Sentry.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@cuisongliu cuisongliu merged commit 7af5505 into labring:main May 9, 2023
58 checks passed
@fengxsong fengxsong deleted the ssh_fetch branch May 26, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants