Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cluster image #3064

Merged
merged 1 commit into from
May 10, 2023
Merged

fix cluster image #3064

merged 1 commit into from
May 10, 2023

Conversation

lingdie
Copy link
Collaborator

@lingdie lingdie commented May 10, 2023

πŸ€– Generated by Copilot at c0adaab

Summary

βœ¨πŸ”§πŸŒ

This pull request adds a new frontend provider for applaunchpad, a web-based tool for creating and launching Kubernetes applications. It also fixes a minor annotation issue in the ingress resource for the applaunchpad-frontend service.

applaunchpad-frontend
New provider for web apps
Spring of creation

Walkthrough

  • Create a new namespace applaunchpad-frontend with a label app: applaunchpad-frontend to isolate the resources for the new frontend provider (link)
  • Add quotation marks around the value of nginx.ingress.kubernetes.io/cors-max-age annotation in the ingress resource definition for the applaunchpad-frontend in frontend/providers/terminal/deploy/manifests/ingress.yaml.tmpl to avoid potential parsing errors and make it consistent with other annotations (link)

@zzjin zzjin merged commit f64db58 into labring:main May 10, 2023
19 checks passed
@lingdie lingdie deleted the fix-image branch May 10, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants