Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(main): enable build flags isolation #3086

Merged
merged 1 commit into from
May 15, 2023

Conversation

cuisongliu
Copy link
Collaborator

@cuisongliu cuisongliu commented May 14, 2023

πŸ€– Generated by Copilot at dcb3296

Summary

πŸš«πŸ› οΈπŸ³

Removed isolation flag from build command in pkg/buildah/common.go. This flag is not needed for sealos, which uses Kubernetes for container management.

isolation flag
gone from build command list
sealos uses k8s

Walkthrough

  • Remove isolation flag from hidden flags in build command (link) to avoid confusion and unnecessary complexity for sealos users

Signed-off-by: cuisongliu <cuisongliu@qq.com>
@codecov
Copy link

codecov bot commented May 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c9f4f58) 72.30% compared to head (dcb3296) 72.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3086   +/-   ##
=======================================
  Coverage   72.30%   72.30%           
=======================================
  Files           8        8           
  Lines         603      603           
=======================================
  Hits          436      436           
  Misses        132      132           
  Partials       35       35           

β˜” View full report in Codecov by Sentry.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@cuisongliu cuisongliu merged commit bcd5a9b into labring:main May 15, 2023
49 checks passed
@cuisongliu cuisongliu deleted the chroot branch May 15, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants