Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix app launchpad env #3099

Merged
merged 6 commits into from
May 16, 2023
Merged

fix app launchpad env #3099

merged 6 commits into from
May 16, 2023

Conversation

lingdie
Copy link
Collaborator

@lingdie lingdie commented May 16, 2023

🤖 Generated by Copilot at 5e0f797

Summary

🔒🚀🐛

This pull request updates the frontend-applaunchpad service to use the ingressSecret environment variable instead of the certSecretName variable for configuring the ingress controller and the application URLs. This change is needed to support the wildcard certificate for the cloud domain. The change affects the sealos deployment script, the Kubefile, the deployment manifest template, and the server-side and client-side code.

INGRESS_SECRET changed
Applaunchpad needs wildcard
Spring of cloud domains

Walkthrough

  • Use ingressSecret instead of certSecretName for frontend-applaunchpad service (link, link, link)
  • Fix typo in default value of INGRESS_SECRET for frontend-applaunchpad service (link, link)

@lingdie lingdie requested a review from c121914yu May 16, 2023 05:22
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ee2693f) 72.30% compared to head (5e0f797) 72.30%.

❗ Current head 5e0f797 differs from pull request most recent head edbe84d. Consider uploading reports for the commit edbe84d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3099   +/-   ##
=======================================
  Coverage   72.30%   72.30%           
=======================================
  Files           8        8           
  Lines         603      603           
=======================================
  Hits          436      436           
  Misses        132      132           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lingdie lingdie merged commit ba49b26 into labring:main May 16, 2023
39 checks passed
@lingdie lingdie deleted the fix-image branch May 16, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants