Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try add db/bytebase controller ci. #3115

Merged
merged 1 commit into from
May 23, 2023
Merged

Try add db/bytebase controller ci. #3115

merged 1 commit into from
May 23, 2023

Conversation

zzjin
Copy link
Collaborator

@zzjin zzjin commented May 23, 2023

πŸ€– Generated by Copilot at c46be4f

Summary

πŸ†•πŸ› οΈπŸ“

The pull request enhances the GitHub workflow for the controllers module by using a matrix structure for the module parameter. This allows for adding the new db-bytebase module and simplifying the workflow file.

To test controllers with ease
We updated the workflow file, please
We used a matrix
For the module prefix
And added support for db-bytebase

Walkthrough

  • Change the matrix for the module parameter from a list of strings to a list of objects with name and path properties in the controllers.yml file. This allows for more flexibility in specifying the module names and paths, especially for the new db-bytebase module that has a different path structure than the others. (link, link)
  • Update the references to the matrix module parameter to use the name and path properties instead of the plain string value in the controllers.yml file. This reflects the change in the matrix structure and ensures the correct paths and names are used for building and naming the binaries, docker images, and outputs. (link, link, link, link, link, link, link, link)
  • Replace the double quotes with single quotes around the input descriptions and default values in the controllers.yml file for consistency with the rest of the file. (link)

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6bdd972) 72.97% compared to head (c46be4f) 72.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3115   +/-   ##
=======================================
  Coverage   72.97%   72.97%           
=======================================
  Files           8        8           
  Lines         618      618           
=======================================
  Hits          451      451           
  Misses        132      132           
  Partials       35       35           

β˜” View full report in Codecov by Sentry.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

Fix typo.

Signed-off-by: zzjin <tczzjin@gmail.com>
@cuisongliu cuisongliu merged commit adc8cb7 into labring:main May 23, 2023
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants