move registry save command to sealctl #3122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengxsong
force-pushed
the
move_registry_commands
branch
from
0bca8b7
to
0e8bb35
Compare
Signed-off-by: fengxsong <fengxsong@outlook.com>
fengxsong
force-pushed
the
move_registry_commands
branch
from
0e8bb35
to
78ab7d1
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3122 +/- ##
=======================================
Coverage 72.97% 72.97%
=======================================
Files 8 8
Lines 618 618
=======================================
Hits 451 451
Misses 132 132
Partials 35 35 ☔ View full report in Codecov by Sentry. |
cuisongliu
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at 0bca8b7
This pull request refactors the registry commands in the
pkg/registry/commandspackage and thesealctlandsealoscommand-line tools to make them more consistent and user-friendly. It simplifies the code, removes unused or redundant components, exports some functions for external use, and uses thecobrapackage for flag validation and error handling. It also adds a new filecmd/sealctl/cmd/registry.goto contain the registry-related commands for thesealctltool.