Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev adminer #3123

Merged
merged 1 commit into from
May 24, 2023
Merged

Dev adminer #3123

merged 1 commit into from
May 24, 2023

Conversation

zzjin
Copy link
Collaborator

@zzjin zzjin commented May 24, 2023

πŸ€– Generated by Copilot at 0f310f9

Summary

πŸ“ˆπŸ›‘οΈπŸŒ

Improved the security and performance of the adminer ingress resource by adding a custom nginx configuration snippet. Increased the memory limit for the adminer container to handle large databases.

Sing, O Muse, of the skillful coder who changed the adminer
And increased its memory limit, from 128Mi to 256Mi
To prevent the dreadful fate of out-of-memory errors
When facing the vast and mighty databases of the cloud.

Walkthrough

  • Increase memory limit for adminer container to 256Mi (link)
  • Add nginx configuration snippet annotation to adminer ingress (link)
  • Import strings package to use ReplaceAll function in getNginxConfigurationSnippet method (link)

@pull-request-size
Copy link

Whoa! Easy there, Partner!

This PR is too big. Please break it up into smaller PRs.

Signed-off-by: zzjin <tczzjin@gmail.com>

temp fix 2

Signed-off-by: zzjin <tczzjin@gmail.com>

rebase Typo.

Signed-off-by: zzjin <tczzjin@gmail.com>

Fix typo2.

Signed-off-by: zzjin <tczzjin@gmail.com>

Fix adminer ingress missing header.

Signed-off-by: zzjin <tczzjin@gmail.com>
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (bf4ed66) 72.97% compared to head (0f310f9) 72.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3123   +/-   ##
=======================================
  Coverage   72.97%   72.97%           
=======================================
  Files           8        8           
  Lines         618      618           
=======================================
  Hits          451      451           
  Misses        132      132           
  Partials       35       35           

β˜” View full report in Codecov by Sentry.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@zzjin zzjin merged commit 189847f into labring:main May 24, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants