Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(main): add registry docs and fix registry save bug #3124

Merged
merged 1 commit into from
May 25, 2023

Conversation

cuisongliu
Copy link
Collaborator

@cuisongliu cuisongliu commented May 24, 2023

🤖 Generated by Copilot at 6b95139

Summary

🚚🐛📝

This pull request enhances the registry save command and its documentation, as well as the related buildimage and password packages. It fixes some bugs, simplifies some logic, and improves the clarity and consistency of the code and the docs. It also renames the --data-dir flag to --registry-dir in registry save.

The registry save command got a makeover
With better docs, flags, and error cover
The buildimage package
Got some logging and format baggage
And the password package removed some leftover

Walkthrough

  • Simplify and update the registry save command and its documentation (link, link, link, link, link, link, link, link, link)
  • Add error and debug log messages to the buildimage and registry packages (link, link, link)
  • Remove unused and unnecessary code from the buildimage and password packages (link, link, link)

Signed-off-by: cuisongliu <cuisongliu@qq.com>
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (bf4ed66) 72.97% compared to head (8ce4139) 72.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3124   +/-   ##
=======================================
  Coverage   72.97%   72.97%           
=======================================
  Files           8        8           
  Lines         618      618           
=======================================
  Hits          451      451           
  Misses        132      132           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fengxsong fengxsong merged commit a1c6a17 into labring:main May 25, 2023
45 checks passed
@cuisongliu cuisongliu deleted the registry branch May 25, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants