Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move apps.displayType to spec. #3133

Merged
merged 3 commits into from
May 25, 2023
Merged

Move apps.displayType to spec. #3133

merged 3 commits into from
May 25, 2023

Conversation

zzjin
Copy link
Collaborator

@zzjin zzjin commented May 25, 2023

πŸ€– Generated by Copilot at 687d2b7

Summary

πŸ†•πŸŽ›οΈπŸ“„

This pull request adds a new DisplayType field to the AppSpec struct and the corresponding CRD for the App resource. This field allows users to control how the App is displayed in the UI.

AppSpec has new field
DisplayType for the UI
Winter of choices

Walkthrough

  • Add DisplayType field to AppSpec struct to control UI display (link)
  • Update CRD for App resource to include displayType property and enum values (link)

zzjin added 3 commits May 25, 2023 12:18
Signed-off-by: zzjin <tczzjin@gmail.com>
Signed-off-by: zzjin <tczzjin@gmail.com>
Signed-off-by: zzjin <tczzjin@gmail.com>
@zzjin zzjin changed the title Dev front Move apps.displayType to spec. May 25, 2023
@bxy4543 bxy4543 merged commit f010bc2 into labring:main May 25, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants