Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support override platform in diff command #3376

Merged
merged 1 commit into from Jun 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/buildah/diff.go
Expand Up @@ -20,6 +20,7 @@ import (
"io"
"os"

"github.com/containers/common/libimage"
"github.com/containers/storage/pkg/archive"
"github.com/spf13/cobra"
"github.com/spf13/pflag"
Expand Down Expand Up @@ -117,6 +118,7 @@ func newDiffCommand() *cobra.Command {
rootCmd.CommandPath()),
}
opts.RegisterFlags(cmd.Flags())
cmd.Flags().AddFlagSet(getPlatformFlags())
cmd.SetUsageTemplate(UsageTemplate())
return cmd
}
Expand Down Expand Up @@ -159,7 +161,7 @@ func runDiff(c *cobra.Command, args []string, opts *diffOption) error {

ctx := getContext()
if diffType == DiffImage {
if args, err = r.pullOrLoadImages(ctx, args...); err != nil {
if args, err = r.PullOrLoadImages(ctx, args, libimage.CopyOptions{}); err != nil {
return err
}
}
Expand Down
3 changes: 2 additions & 1 deletion pkg/buildah/interface.go
Expand Up @@ -20,6 +20,7 @@ import (

"github.com/containers/buildah"
"github.com/containers/buildah/pkg/parse"
"github.com/containers/common/libimage"
"github.com/containers/image/v5/transports"
"github.com/containers/image/v5/types"
"github.com/containers/storage"
Expand Down Expand Up @@ -235,7 +236,7 @@ func (impl *realImpl) ListContainers() ([]JSONContainer, error) {

func (impl *realImpl) Load(input string, transport string) (string, error) {
ref := FormatReferenceWithTransportName(transport, input)
names, err := impl.runtime.pullOrLoadImages(getContext(), ref)
names, err := impl.runtime.PullOrLoadImages(getContext(), []string{ref}, libimage.CopyOptions{})
if err != nil {
return "", err
}
Expand Down
14 changes: 7 additions & 7 deletions pkg/buildah/runtime.go
Expand Up @@ -89,7 +89,11 @@ func (r *Runtime) getLayerID(id string, diffType DiffType) (string, error) {
return "", fmt.Errorf("%s not found: %w", id, lastErr)
}

func (r *Runtime) pullOrLoadImages(ctx context.Context, args ...string) ([]string, error) {
func (r *Runtime) PullOrLoadImages(ctx context.Context, args []string, options libimage.CopyOptions) ([]string, error) {
copyOpts := options
if copyOpts.Writer == nil {
copyOpts.Writer = os.Stderr
}
var result []string
for i := range args {
name := args[i]
Expand All @@ -103,9 +107,7 @@ func (r *Runtime) pullOrLoadImages(ctx context.Context, args ...string) ([]strin
ref = strings.TrimPrefix(ref, "//")
}
pullImages, err := r.Runtime.Pull(ctx, ref, config.PullPolicyMissing, &libimage.PullOptions{
CopyOptions: libimage.CopyOptions{
Writer: os.Stderr,
},
CopyOptions: copyOpts,
})
if err != nil {
return nil, err
Expand All @@ -123,9 +125,7 @@ func (r *Runtime) pullOrLoadImages(ctx context.Context, args ...string) ([]strin
ref = filepath.Join(cwd, ref)
}
images, err := r.Runtime.Load(ctx, ref, &libimage.LoadOptions{
CopyOptions: libimage.CopyOptions{
Writer: os.Stderr,
},
CopyOptions: copyOpts,
})
if err != nil {
return nil, err
Expand Down
4 changes: 3 additions & 1 deletion pkg/buildah/util.go
Expand Up @@ -15,6 +15,8 @@
package buildah

import (
"github.com/containers/common/libimage"

"github.com/labring/sealos/pkg/utils/file"
)

Expand All @@ -27,7 +29,7 @@ func PreloadIfTarFile(images []string, transport string) ([]string, error) {
for i := range images {
if file.IsTarFile(images[i]) {
ref := FormatReferenceWithTransportName(transport, images[i])
names, err := r.pullOrLoadImages(getContext(), ref)
names, err := r.PullOrLoadImages(getContext(), []string{ref}, libimage.CopyOptions{})
if err != nil {
return nil, err
}
Expand Down