New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add and delete master or worker nodes with different ssh settings #3525
Conversation
🤖 Generated by lychee actionSummary
Full action output |
I will submit the test report later |
issue #3492 |
issue #3492 |
IMO, it's unnecessary to modify the interface sealos/pkg/bootstrap/context.go Line 29 in dd81a81
sealos/pkg/filesystem/filesystem.go Line 25 in dd81a81
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3525 +/- ##
==========================================
- Coverage 72.97% 67.92% -5.06%
==========================================
Files 8 8
Lines 618 664 +46
==========================================
Hits 451 451
- Misses 132 171 +39
- Partials 35 42 +7
☔ View full report in Codecov by Sentry. |
let me have a look |
99c21c6
to
330b046
Compare
Signed-off-by: yangxg <yangxggo@163.com>
5cd6757
to
bb803fb
Compare
Signed-off-by: fengxsong <fengxsong@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/cherry-pick release-v4.3 |
🤖 says: cherry pick action finished successfully 🎉! |
feature:
support add and delete master or worker nodes with different ssh settings.
for example:
sealos add --masters 10.10.12.19 -p test@2
sealos add --nodes 10.10.12.17 -p test@4
sealos add --nodes 10.10.12.32 -p test@3
and delete command does not need to specify the different password:
sealos delete --masters 10.10.12.19 --nodes 10.10.12.17,10.10.12.32
my solution: