Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use cert-manager to gen tls cert and secret. #3540

Merged
merged 6 commits into from Jul 19, 2023
Merged

Conversation

lingdie
Copy link
Collaborator

@lingdie lingdie commented Jul 19, 2023

🤖 Generated by Copilot at c47a73e

Summary

🐳📜🚀

This pull request adds a new way to generate and distribute a mock TLS certificate for sealos in cloud environments. It copies the registry binary to the image, creates a Kubernetes job that runs mock-cert-job.yaml to generate a self-signed certificate and a secret, and modifies init.sh to apply the job instead of creating the secret locally.

registry copied
mock-cert-job creates secret
simpler init.sh - spring

Walkthrough

  • Copy registry binary to image for running local container registry (link)
  • Add Kubernetes job to generate mock TLS certificate and create secret with reflector labels (link)
  • Replace local certificate generation and application with kubectl apply of mock-cert-job.yaml in init.sh script (link)

@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Jul 19, 2023

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 903
✅ Successful 337
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 565
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@zzjin zzjin added this to the v5.0 milestone Jul 19, 2023
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (74beff7) 72.97% compared to head (650c00f) 72.97%.

❗ Current head 650c00f differs from pull request most recent head d1ea5d9. Consider uploading reports for the commit d1ea5d9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3540   +/-   ##
=======================================
  Coverage   72.97%   72.97%           
=======================================
  Files           8        8           
  Lines         618      618           
=======================================
  Hits          451      451           
  Misses        132      132           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Jul 19, 2023
@pull-request-size pull-request-size bot added size/M and removed size/L labels Jul 19, 2023
@lingdie lingdie changed the title feat: use k8s job to gen tls cert and secret. feat: use cert-manager to gen tls cert and secret. Jul 19, 2023
@lingdie lingdie merged commit 4ebacd8 into labring:main Jul 19, 2023
33 checks passed
@lingdie lingdie deleted the cloud branch July 19, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants