Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check hostname unique in creating new cluster #3569

Merged
merged 1 commit into from Jul 22, 2023
Merged

fix: check hostname unique in creating new cluster #3569

merged 1 commit into from Jul 22, 2023

Conversation

yangxggo
Copy link
Contributor

fix issue #3527

add ip list to check hostname

@yangxggo
fix: check hostname unique in creating new cluster
d617a90 
Signed-off-by: yangxg <yangxggo@163.com>
@sealos-ci-robot
Copy link
Member

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 914
✅ Successful 347
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 566
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (52a9d1c) 72.97% compared to head (d617a90) 72.97%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3569   +/-   ##
=======================================
  Coverage   72.97%   72.97%           
=======================================
  Files           8        8           
  Lines         618      618           
=======================================
  Hits          451      451           
  Misses        132      132           
  Partials       35       35

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cuisongliu cuisongliu added this to the v4.3 milestone Jul 22, 2023
@cuisongliu cuisongliu linked an issue Jul 22, 2023 that may be closed by this pull request
BUG: sealos apply not check Duplicate of hostname #3527
Closed
@cuisongliu cuisongliu merged commit c530333 into labring:main Jul 22, 2023
82 checks passed
@sealos-ci-robot
Copy link
Member

/cherry-pick release-v4.3

@sealos-ci-robot
Copy link
Member

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/labring/sealos/actions/runs/5630103584

sealos-ci-robot pushed a commit that referenced this pull request Jul 22, 2023
@yangxggo
fix: check hostname unique in creating new cluster (#3569)
f1c9bac 
Signed-off-by: yangxg <yangxggo@163.com>
cuisongliu pushed a commit that referenced this pull request Jul 22, 2023
@sealos-ci-robot @yangxggo
fix: check hostname unique in creating new cluster (#3569) (#3570)
a40ff91 
Signed-off-by: yangxg <yangxggo@163.com>
Co-authored-by: yangxg <53515649+yangxggo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuisongliu cuisongliu cuisongliu approved these changes

Assignees
No one assigned
Labels
area/apply sealos run/apply/scale/reset area/check area/lifecycle-management size/S
Projects
None yet
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.

BUG: sealos apply not check Duplicate of hostname
3 participants
@yangxggo @sealos-ci-robot @cuisongliu