New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose mongo uri. #3586
Merged
Merged
feat: expose mongo uri. #3586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
π€ Generated by lychee actionSummary
Full action output |
bxy4543
approved these changes
Jul 26, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3586 +/- ##
=======================================
Coverage 67.92% 67.92%
=======================================
Files 8 8
Lines 664 664
=======================================
Hits 451 451
Misses 171 171
Partials 42 42 β View full report in Codecov by Sentry. |
lingdie
added a commit
to lingdie/sealos
that referenced
this pull request
Jul 26, 2023
* feat: expose mongo uri. (labring#3586) * expose mongo uri env. * feat: operation request -> rolebinding (sa <-> role) * feat: operation request -> rolebinding (sa <-> role) * feat: operation request --------- Co-authored-by: yy <56745951+lingdie@users.noreply.github.com>
bxy4543
pushed a commit
to bxy4543/sealos
that referenced
this pull request
Jul 27, 2023
* expose mongo uri env.
lingdie
added a commit
that referenced
this pull request
Aug 21, 2023
β¦ller. (#3595) * User (#7) * feat: expose mongo uri. (#3586) * expose mongo uri env. * feat: operation request -> rolebinding (sa <-> role) * feat: operation request -> rolebinding (sa <-> role) * feat: operation request --------- Co-authored-by: yy <56745951+lingdie@users.noreply.github.com> * init user controller for multi namespace feat. * fix makefile. * add samples * init operation request webhook. * init operationrequest webhook * fix create rolebinding and log error. * add samples. * print status and other info. * fix lint/makefile, add label for rolebinding * fix crd. * fix const. --------- Co-authored-by: xy <135087223+Yurnero-Xy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π€ Generated by Copilot at 9489259
Summary
πππ£οΈ
This pull request adds support for using an external mongodb database for sealos-cloud deployments. It introduces a new environment variable
mongodbUri
in theKubefile
and theinit.sh
script, and updates theREADME.md
file to explain how to use it.Walkthrough
mongodbUri
environment variable (link, link, link)Kubefile
to accept themongodbUri
value and pass it to theinit.sh
script (link)README.md
file to explain the new option and provide an example command (link)init.sh
script to indicate whether the kubeblocks mongodb custom resource will be applied or not (link)