Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom domain port #3635

Merged
merged 1 commit into from Aug 4, 2023
Merged

feat: custom domain port #3635

merged 1 commit into from Aug 4, 2023

Conversation

c121914yu
Copy link
Collaborator

@c121914yu c121914yu commented Aug 4, 2023

πŸ€– Generated by Copilot at 4a4c21d

Summary

πŸš€πŸ› οΈπŸ”„

This pull request adds support for using and displaying the port number for the app launchpad domain name. It modifies the backend API, the frontend components, the static store, and the deployment manifests to use the DOMAIN_PORT environment variable. It also fixes a dependency issue in the App component.

Sing, O Muse, of the cunning code changes
That the skilled developers wrought with their hands
To enhance the app launchpad, the portal of wonders
That lets users create and deploy their own lands

Walkthrough

  • Add a new environment variable DOMAIN_PORT to store and access the port number for the app launchpad service (link, link, link, link, link, link, link)
  • Modify the logic for generating the external access URL for an app to append the port number if it is not empty (link, link, link, link)
  • Add the initFormSliderList dependency to the useEffect hook in the App component in _app.tsx to ensure the slider list for the app edit form is initialized correctly (link)

@sealos-ci-robot
Copy link
Member

πŸ€– Generated by lychee action

Summary

Status Count
πŸ” Total 918
βœ… Successful 351
⏳ Timeouts 0
πŸ”€ Redirected 0
πŸ‘» Excluded 566
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6584695) 67.92% compared to head (4a4c21d) 67.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3635   +/-   ##
=======================================
  Coverage   67.92%   67.92%           
=======================================
  Files           8        8           
  Lines         664      664           
=======================================
  Hits          451      451           
  Misses        171      171           
  Partials       42       42           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@zzjin zzjin added this to the v5.0 milestone Aug 4, 2023
@zzjin zzjin merged commit c4baed2 into labring:main Aug 4, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants