Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(main): fix: skip pulling app image #3649

Merged
merged 1 commit into from Aug 9, 2023
Merged

fix(main): fix: skip pulling app image #3649

merged 1 commit into from Aug 9, 2023

Conversation

cuisongliu
Copy link
Collaborator

@cuisongliu cuisongliu commented Aug 9, 2023 •
edited by ghost

🤖 Generated by Copilot at 32e6961

Summary

♻️⚡⛰️

This pull request improves the logic and performance of the MountClusterImages function in the pkg/apply/processor package. It simplifies the image type check in interface.go and avoids unnecessary mount operations in scale.go.

MountClusterImages
Only when scaling up cluster -
Winter pruning

Walkthrough

  • Simplify the logic of checking the image type in MountClusterImages (link)
  • Move the call to MountClusterImages inside the scale-up block in preProcess to avoid unnecessary mount operations (link)

@cuisongliu
fix(main): fix: skip pulling app image
32e6961 
Signed-off-by: cuisongliu <cuisongliu@qq.com>
@sealos-ci-robot
Copy link
Member

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 885
✅ Successful 348
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 536
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@cuisongliu cuisongliu added this to the v4.3 milestone Aug 9, 2023
@cuisongliu cuisongliu linked an issue Aug 9, 2023 that may be closed by this pull request
BUG: sealos add seem pull image #3403
Closed
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f104b5f) 67.92% compared to head (32e6961) 67.92%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3649   +/-   ##
=======================================
  Coverage   67.92%   67.92%           
=======================================
  Files           8        8           
  Lines         664      664           
=======================================
  Hits          451      451           
  Misses        171      171           
  Partials       42       42

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cuisongliu cuisongliu merged commit 81609b2 into labring:main Aug 9, 2023
80 checks passed
@cuisongliu cuisongliu deleted the fix_pull_image branch August 9, 2023 08:23
@sealos-ci-robot
Copy link
Member

/cherry-pick release-v4.3

@sealos-ci-robot
Copy link
Member

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/labring/sealos/actions/runs/5806651183

sealos-ci-robot pushed a commit that referenced this pull request Aug 9, 2023
@cuisongliu
fix(main): fix: skip pulling app image (#3649)
a95e7c9 
Signed-off-by: cuisongliu <cuisongliu@qq.com>
cuisongliu added a commit that referenced this pull request Aug 9, 2023
@sealos-ci-robot @cuisongliu
fix(main): fix: skip pulling app image (#3649) (#3650)
296db1a 
Signed-off-by: cuisongliu <cuisongliu@qq.com>
Co-authored-by: cuisongliu <cuisongliu@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengxsong fengxsong fengxsong approved these changes

Assignees
No one assigned
Labels
area/apply sealos run/apply/scale/reset area/lifecycle-management size/S
Projects
None yet
Milestone
v4.3
Development

Successfully merging this pull request may close these issues.

BUG: sealos add seem pull image
3 participants
@cuisongliu @sealos-ci-robot @fengxsong