Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:desktop add umami #3676

Merged
merged 1 commit into from Aug 16, 2023
Merged

feat:desktop add umami #3676

merged 1 commit into from Aug 16, 2023

Conversation

zjy365
Copy link
Contributor

@zjy365 zjy365 commented Aug 14, 2023

🤖 Generated by Copilot at bd80517

Summary

📊🧹🐛

This pull request adds Umami analytics to the home page of the sealos app and improves the code quality and functionality of the deploy page. It uses next/script and UMAMI_URL to load the analytics script and fixes a bug with the YAML string generation.

Sing, O Muse, of the sealos app, the wondrous work of code
That tracks the visitors of its home with Umami's mode
Using next/script and UMAMI_URL, the Script component they invoke
To load the analytics script and measure every stroke

Walkthrough

  • Load Umami analytics script in the index page using next/script component (link, link, link, link, link)
  • Simplify the logic of fetching and using cached values for the YAML editor in the deploy page (link, link, link)
  • Remove unused imports from the deploy page (link)

@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Aug 14, 2023

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 885
✅ Successful 348
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 536
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9c3d1a9) 67.77% compared to head (d86e609) 67.77%.
Report is 5 commits behind head on main.

❗ Current head d86e609 differs from pull request most recent head 894b35a. Consider uploading reports for the commit 894b35a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3676   +/-   ##
=======================================
  Coverage   67.77%   67.77%           
=======================================
  Files           8        8           
  Lines         661      661           
=======================================
  Hits          448      448           
  Misses        171      171           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: jingyang <3161362058@qq.com>
@c121914yu c121914yu merged commit 3be0e8f into labring:main Aug 16, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants