Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: admission webhook for sealos #3678

Merged
merged 13 commits into from Aug 17, 2023
Merged

Conversation

lingdie
Copy link
Collaborator

@lingdie lingdie commented Aug 15, 2023

🤖 Generated by Copilot at 6a73769

Summary

🎛️🚧🚀

This pull request adds a new admission controller subproject under the controllers directory. It scaffolds the project using kubebuilder and sets up the necessary files for building, testing, deploying, and running the admission controller. It also configures the GitHub workflow, docker image, and kustomize manifests for the admission controller.

admission born
scaffolded with kustomize
Dockerfile blooms

Walkthrough

  • Add a new subproject for the admission controller under the controllers directory (link)
  • Create the main entry point for the admission controller binary in main.go (link)
  • Define the docker image for the admission controller in Dockerfile (link)
  • Define the makefile for building, testing, and deploying the admission controller in Makefile (link)
  • Define the project metadata for scaffolding and plugins in PROJECT (link)
  • Create the documentation file for the admission controller in README.md (link)
  • Create the .gitignore and .dockerignore files for ignoring unwanted files and directories (link, link)
  • Define the kustomize bases and overlays for the admission controller manifests in config directory (link, link, link, link)
  • Define the patches for the manager deployment, including the auth proxy sidecar and the config args (link, link)
  • Define the manager manifest for the controller manager deployment and service in config/manager/manager.yaml (link)
  • Define the prometheus monitor manifest for the controller manager metrics service in config/prometheus/monitor.yaml (link)
  • Define the rbac manifests for the service account, roles, role bindings, and auth proxy service in config/rbac directory (link, link, link, link)

@pull-request-size
Copy link

Whoa! Easy there, Partner!

This PR is too big. Please break it up into smaller PRs.

@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Aug 15, 2023

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 907
✅ Successful 370
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 536
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (dd4d67b) 67.77% compared to head (b6f31a0) 67.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3678   +/-   ##
=======================================
  Coverage   67.77%   67.77%           
=======================================
  Files           8        8           
  Lines         661      661           
=======================================
  Hits          448      448           
  Misses        171      171           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lingdie lingdie added this to the v5.0 milestone Aug 16, 2023
@lingdie lingdie merged commit 1f8dc52 into labring:main Aug 17, 2023
65 checks passed
@lingdie lingdie deleted the admission-controller branch October 13, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants