Community edition dev #3712
Merged
Community edition dev #3712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Generated by lychee actionSummary
Full action output |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3712 +/- ##
=======================================
Coverage 66.36% 66.36%
=======================================
Files 8 8
Lines 654 654
=======================================
Hits 434 434
Misses 173 173
Partials 47 47 ☔ View full report in Codecov by Sentry. |
yxxchange
force-pushed
the
community-edition-dev
branch
from
c01e91f
to
fdc2e71
Compare
yxxchange
force-pushed
the
community-edition-dev
branch
from
fdc2e71
to
33343d4
Compare
bxy4543
approved these changes
Aug 21, 2023
lingdie
requested changes
Aug 21, 2023
| err = presetRootUser(context.Background(), options) | ||
| fmt.Println("failed to preset root user, retrying...") | ||
| if err != nil { | ||
| time.Sleep(time.Minute) |
There was a problem hiding this comment.
It is ok by testing
|
|
||
| const ( | ||
| // pre-defined user name and password | ||
| defaultuser = "root" |
|
|
||
| // kubernetes default user cr is admin | ||
| // it is corresponding to the root account | ||
| defaultK8sUser = "admin" |
There was a problem hiding this comment.
rename to defaultCloudUser.
There was a problem hiding this comment.
it not a good idear to rename this
Comment on lines
+67
to
+68
| defaultDB = "test" | ||
| defaultCollection = "user" |
There was a problem hiding this comment.
or just use mongoURI to connect db, do not set this.
| passwd := hashPassword(defaultPassword, o.GetEnvOptions().SaltKey) | ||
| user := newUser(uuid, defaultuser, defaultuser, passwd, defaultK8sUser) | ||
|
|
||
| collection := client.Database(defaultDB).Collection(defaultCollection) |
| } | ||
| err = client.Ping(ctx, nil) | ||
| if err != nil { | ||
| fmt.Println("failed to ping mongo", err) |
yxxchange
force-pushed
the
community-edition-dev
branch
from
1cd7d81
to
65dcc7b
Compare
lingdie
approved these changes
Aug 21, 2023
yxxchange
force-pushed
the
community-edition-dev
branch
from
65dcc7b
to
cc39413
Compare
lingdie
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at 348745f
Summary
🔑🚀🛠️
This pull request refactors and updates the license issuer controller to use a new command, a new license key mechanism, and new RBAC permissions. It also adds two new binaries,
presetandlauncher, to simplify the MongoDB initialization and the controller execution. It modifies themanager.yaml,deploy.yaml,license_controller.go,init.go,Makefile,role.yaml,configmaps.yaml,Dockerfile,const.go,main.gofiles, and the.github/workflows/controllers.ymlworkflow.Walkthrough
launcherbinary to runpresetandmanagerbinaries in sequence (link, link, link, link, link)presetbinary to preset the root user for MongoDB (link, link, link, link, link, link)LICENSE_KEYenvironment variable (link, link, link)namespaces,nodes, andpersistentvolumesresources for the controller (link, link, link)LauncherCRD and related logic from the controller (link, link, link)imagePullPolicy: Alwaysto the manager deployment manifest (link, link)keyandnamefields ofsecretKeyReffor consistency (link, link)init.gofile (link)license_controller.gofile (link)