Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:template git err & terminal insufficient balance #3755

Merged
merged 3 commits into from Aug 23, 2023

Conversation

zjy365
Copy link
Contributor

@zjy365 zjy365 commented Aug 23, 2023

πŸ€– Generated by Copilot at 54cf1ed

Summary

🚨πŸ–₯️🌐

This pull request adds and improves features for the frontend providers of the sealos platform. It enables getting the user's namespace from the Kubernetes cluster, refactors the code for updating repositories, adds error handling and user feedback for the terminal service, and removes some unnecessary newlines. It also modifies some console error messages and creates a simple error page for the terminal provider.

We're sailing on the code sea, with error.tsx and SEALOS_NAMESPACE
We're refactoring and handling, making sure our code is ace
Heave away, me jollies, heave away
On the count of three, we'll pull and execAsync

Walkthrough

  • Import and use backend services to get user's namespace and kubeconfig from Kubernetes cluster (link, link, link)
  • Replace exec with execAsync and use await to simplify and ensure proper execution of shell commands in updateRepo.ts (link, link)
  • Remove newline characters after > symbols in JSX elements to improve code formatting in develop/index.tsx (link, link, link)
  • Add string ------------\n to console.error message to make it more visible in response.ts (link)
  • Create and export ErrPage component to render a simple error page in error.tsx (link)
  • Use useToast hook to display toast notifications and handle error case when user has insufficient balance to use terminal service in index.tsx (link, link, link)

Signed-off-by: jingyang <3161362058@qq.com>
Signed-off-by: jingyang <3161362058@qq.com>
Signed-off-by: jingyang <3161362058@qq.com>
@sealos-ci-robot
Copy link
Member

πŸ€– Generated by lychee action

Summary

Status Count
πŸ” Total 909
βœ… Successful 372
⏳ Timeouts 0
πŸ”€ Redirected 0
πŸ‘» Excluded 536
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e1a6958) 66.46% compared to head (54cf1ed) 66.46%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3755   +/-   ##
=======================================
  Coverage   66.46%   66.46%           
=======================================
  Files           8        8           
  Lines         656      656           
=======================================
  Hits          436      436           
  Misses        173      173           
  Partials       47       47           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@c121914yu c121914yu merged commit 65797c4 into labring:main Aug 23, 2023
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants