launchpad imagePullPolicy #3775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Generated by lychee actionSummary
Full action output |
zzjin
approved these changes
Aug 28, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3775 +/- ##
=======================================
Coverage 66.71% 66.71%
=======================================
Files 8 8
Lines 661 661
=======================================
Hits 441 441
Misses 173 173
Partials 47 47 ☔ View full report in Codecov by Sentry. |
zzjin
approved these changes
Aug 29, 2023
lingdie
added a commit
to lingdie/sealos
that referenced
this pull request
Aug 29, 2023
* Fix/debt webhook config (labring#3777) * fix webhook policy cause api-server busy * fix account status via webhook * style: rename some functions and constants related with runtime implementation (labring#3763) * style: rename constants.Data to PathResolver * style: move non-generic constants to respective module directories * style: rename functions * fix: path of remote config dir * fix: path of kubeadm init and upate file in e2e test * fix: avoid reusing the private ConvertedKubeadmConfig * style: rename ConfigsPath * feat:cronjob deploy & desktop background (labring#3776) * feat:cronjob deploy Signed-off-by: jingyang <3161362058@qq.com> * desktop background Signed-off-by: jingyang <3161362058@qq.com> * delete serviceAccount * backgrond svg --------- Signed-off-by: jingyang <3161362058@qq.com> * feat:template develop dryrun deploy (labring#3778) Signed-off-by: jingyang <3161362058@qq.com> * Count pods that not in succeeded & watch gpu changes on nodes (labring#3754) * fix: count pods that not in succeeded * feat: watch gpu changes on nodes * fix golangci-lint * fix * abstract methods * fix golangci-lint * launchpad imagePullPolicy (labring#3775) * add sealos cloud arm64 cluster image --------- Signed-off-by: jingyang <3161362058@qq.com> Co-authored-by: Jiahui <4543bxy@gmail.com> Co-authored-by: fengxsong <fengxsong@outlook.com> Co-authored-by: zhujingyang <72259332+zjy365@users.noreply.github.com> Co-authored-by: xuziyi <nowinkey@tom.com> Co-authored-by: Archer <545436317@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at a0d77fc
Summary
🔄🆙🛠️
Changed the
imagePullPolicyof the container spec toAlwaysin two files:apps.tsanddeployYaml2Json.ts. This ensures that the container always runs the latest version of the app.Walkthrough
imagePullPolicytoAlwaysfor the container spec of the app deployment (link, link). This ensures that the container always pulls the latest image from the registry, instead of using a cached one if it exists. This change affects both the original YAML file (frontend/providers/applaunchpad/src/mock/apps.ts) and the function that converts it to a JSON object (frontend/providers/applaunchpad/src/utils/deployYaml2Json.ts).