New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support rendering template files on target host with sealctl #3872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Generated by lychee actionSummary
Full action output |
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
cuisongliu
approved these changes
Sep 8, 2023
/cherry-pick release-v4.4 |
🤖 says: cherry pick action finished successfully 🎉! |
sealos-ci-robot
pushed a commit
that referenced
this pull request
Sep 8, 2023
…3872) * fix: return reader.Read error if not nil * refactor: the initsystem commands * feat: add render template subcommand for sealctl * feat: support rendering template files on target host with sealctl * fix: merge envs from rootfs and render shell with it
cuisongliu
pushed a commit
that referenced
this pull request
Sep 8, 2023
…3872) (#3874) * fix: return reader.Read error if not nil * refactor: the initsystem commands * feat: add render template subcommand for sealctl * feat: support rendering template files on target host with sealctl * fix: merge envs from rootfs and render shell with it Co-authored-by: fengxsong <fengxsong@outlook.com>
bxy4543
pushed a commit
to bxy4543/sealos
that referenced
this pull request
Oct 13, 2023
…abring#3872) * fix: return reader.Read error if not nil * refactor: the initsystem commands * feat: add render template subcommand for sealctl * feat: support rendering template files on target host with sealctl * fix: merge envs from rootfs and render shell with it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at 7dff684
Summary
🎨🐛📁
This pull request improves the code quality and functionality of the sealos project. It simplifies the creation of init system subcommands, updates the rootfs package to use the
filepath
package and thesealctl render
command, adds a new file matching function to thefile
package, implements a new render command for sealctl, removes an unused function from the template package, and fixes a bug in the yaml package.Walkthrough